Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated target initialization #14

Open
JStech opened this issue Aug 10, 2020 · 0 comments · May be fixed by #86
Open

Repeated target initialization #14

JStech opened this issue Aug 10, 2020 · 0 comments · May be fixed by #86
Labels
enhancement New feature or request

Comments

@JStech
Copy link
Contributor

JStech commented Aug 10, 2020

The TargetTabWidget::imageCallback function (in moveit_calibration_gui/handeye_calibration_rviz_plugin/src/handeye_target_widget.cpp) creates a new target object every time it is called. Since the target initialization generates some info messages, this ends up spamming the terminal. I'll have to look into it further, but it seems unnecessary to recreate the target with each image--it's probably sufficient to verify that it has been created, and to only re-initialize if the parameters change.

@JStech JStech added the enhancement New feature or request label Feb 18, 2021
@JStech JStech linked a pull request May 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant