Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMD Track: MoveIt Config Utils #1292

Closed
JafarAbdi opened this issue May 31, 2022 · 4 comments · Fixed by #1308
Closed

WMD Track: MoveIt Config Utils #1292

JafarAbdi opened this issue May 31, 2022 · 4 comments · Fixed by #1308

Comments

@JafarAbdi
Copy link
Member

No description provided.

@AndyZe
Copy link
Member

AndyZe commented May 31, 2022

Here's an issue:

moveit_configs_utils/moveit_configs_utils/moveit_configs_builder.py

    if not possible_names:
            logging.warn(
                "trajectory_execution: `Parameter file_path is undefined "
                f"and no matches for {config_folder}/*_controllers.yaml"

I think this is a bad idea because it will catch ros2_controllers.yaml as well as moveit_controllers.yaml

@DLu
Copy link
Contributor

DLu commented May 31, 2022

#1296

@DLu
Copy link
Contributor

DLu commented May 31, 2022

#1297

@JafarAbdi
Copy link
Member Author

Refactor MoveItConfigs to be decorated with dataclass

from dataclasses import dataclass

@dataclass(slots=True)
class MoveItConfigs:
    something: Type = DefaultValue
    ...

This would save us from having the following for each parameter

__slots__ = [
    "__something",
    ...
]

@property
def something(self):
    return self.__something

@something.setter
def something(self, value):
    self.__something = value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants