Google Slides & Google Drive #1031
Conversation
|
|
||
| @unittest.skipIf( | ||
| not os.environ.get("LIVE_TEST"), "Skipping because not running live test" | ||
| ) |
There was a problem hiding this comment.
You've set this up so that all of your tests will be skipped unless the environmental variable is set to LIVE_TEST. It's great to have live tests, but we also want tests using Mocks that can be run as part of the regular automated testing pipeline. Can you also write some mock versions?
There was a problem hiding this comment.
Also, for the live tests, will everyone have access to the test slides you've created? If not, instead of hard coding that variable into the tests, we likely want to create another environmental variable people can use.
There was a problem hiding this comment.
Also, for the live tests, will everyone have access to the test slides you've created? If not, instead of hard coding that variable into the tests, we likely want to create another environmental variable people can use.
YES the Test Slides are public to everyone on the internet (they contain truly nothing of value). I think given the nature of the tests - in terms of replacing certain text and images, we need to use a standard default.
|
re: the docs, I don't see any updates to the docs. You'll want to edit the google.rst file to include docs on your new connectors. You can use the sections that are already there (ie Google Sheets, Google Admin) as a template. You can also use these instructions as a guide, although your case is a little different because you're not creating a completely new connector, so you don't need to create a completely new Building the docs locally is a little tricky, you can follow these steps - a common issue is people not realizing they need to go into the docs folder and install some docs-specific requirements before trying to build the docs. |
|
Weirdly only two of the dozen or so tests is being run (both passing, though!) and there are merge conflicts. @elyse-weiss would you be up for pairing on this sometime soon, and we can work through the issues together and get this merged? |
|
@shaunagm happy to pair! would love to get this merged :) |
|
@shaunagm tests ran successfully locally! |
| setup_google_application_credentials( | ||
| google_keyfile_dict, "GOOGLE_DRIVE_CREDENTIALS" | ||
| ) | ||
| google_credential_file = open(os.environ["GOOGLE_DRIVE_CREDENTIALS"]) | ||
| credentials_dict = json.load(google_credential_file) | ||
|
|
||
| credentials = Credentials.from_service_account_info( | ||
| credentials_dict, scopes=scope, subject=subject | ||
| ) |
There was a problem hiding this comment.
@austinweisgrau I previously had:
self.client = build("drive", "v3", credentials=credentials)
If I follow your code from the other PR, will the following work too:
self.client = AuthorizedSession(credentials)
There was a problem hiding this comment.
Same comments on google_drive apply to this connector
Closes #957
Notes