Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds board saving to localStorage #1

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Adds board saving to localStorage #1

wants to merge 26 commits into from

Conversation

PersonalPalimpsest
Copy link
Contributor

Allows for tracking board stats (items gained, rarity, type, tickets used) in a JSON object.

@PersonalPalimpsest
Adds board saving to localStorage
48bb50a 
Allows for tracking board stats (items gained, rarity, type, tickets used) in a JSON object.
@PersonalPalimpsest
formatting update to reduce changes
7ed7729
@PersonalPalimpsest
fixing more leftover crud to reduce changes
d4a7494
bradp
bradp reviewed Nov 3, 2022
View reviewed changes
mh-better-spooky-shuffle-tracker.user.js Outdated
Comment on lines 163 to 178
position: relative;
}

.mh-spooky-shuffle-card-front {
opacity: .75;
}

.mh-spooky-shuffle-card-name {
text-align: center;
position: absolute;
bottom: 5px;
width: 100px;
background-color: #ffcdcf;
border-radius: 5px;
box-shadow: 0px 1px 2px 1px #970707;
padding: 5px 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the styles?

@bradp
Copy link
Member

bradp commented Nov 3, 2022

Looks like there's some issues with this PR. Mind taking a look and making sure the lint passes?

@bradp
Copy link
Member

bradp commented Nov 3, 2022

Looks like linting is still failing.
You can check locally but running npm run lint and fix any auto-correctable errors with npm run lint:fix.

@PersonalPalimpsest
Copy link
Contributor Author

Looks like linting is still failing. You can check locally but running npm run lint and fix any auto-correctable errors with npm run lint:fix.

tbh i have no idea what that is or how to run it locally

@PersonalPalimpsest
Copy link
Contributor Author

i just spent way too long trying to figure it out and not really making any progress so giving up for now. script works for me 🤷

@bradp bradp mentioned this pull request Nov 3, 2022
Merged
@bradp
Copy link
Member

bradp commented Nov 4, 2022

@PersonalPalimpsest Merged #2, so you should be able to pull main, but just watch out for conflicts.
If you've already made some changes and resolving conflicts will be difficult, then don't worry about it for now and I'll just help clean up your branch afterwards

@PersonalPalimpsest
Copy link
Contributor Author

@bradp Resolving conflicts was difficult, but I took some of the suggestions and implemented them into the latest commit. Some of the suggested changes broke parts of the script so they needed some fixing but it's back to working overall for me now.

None of the other online linting tools I've tried were so aggressive about removing the debug/console.log stuff, not sure why there's a need to remove those as I've found them really helpful for whenever an update breaks things.

@bradp
Copy link
Member

bradp commented Oct 9, 2023

I’m going to get this merged in before the event 🙏

@bradp
Copy link
Member

bradp commented Oct 11, 2023

I’m going to get this merged in before at the start of the event so we can test it

@PersonalPalimpsest
Merging board saving and summary functions to Brad's 1.3.0
9468357 
Also some minor changes to comments and logging for clarity
@PersonalPalimpsest
Copy link
Contributor Author

doesn't seem like the board saving stuff was merged in so i did it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradp bradp bradp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PersonalPalimpsest @bradp