Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid depending on typing_extensions where not needed #652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zware
Copy link
Contributor

@zware zware commented Nov 27, 2024

Fixes #649 (I think 🙂)

@coveralls
Copy link

coveralls commented Nov 27, 2024

Coverage Status

coverage: 91.901% (+0.02%) from 91.886%
when pulling cf1259e on zware:patch-1
into 0254a4b on mosquito:master.

@zware zware force-pushed the patch-1 branch 3 times, most recently from 1de6e3d to c62c66e Compare November 27, 2024 19:15
@zware
Copy link
Contributor Author

zware commented Nov 27, 2024

Now with more surety, fixes #649 :)

mosquito
mosquito previously approved these changes Nov 27, 2024
@mosquito mosquito dismissed their stale review November 28, 2024 14:52

The merge-base changed after approval.

@zware
Copy link
Contributor Author

zware commented Nov 29, 2024

Not really sure what happened (looks like master was force-pushed?), but now rebased.

@zware zware requested a review from mosquito December 2, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'typing_extensions'
3 participants