Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueueIterator implicit cancellation can be suppressed #623

Open
pohmelie opened this issue Mar 27, 2024 · 2 comments
Open

QueueIterator implicit cancellation can be suppressed #623

pohmelie opened this issue Mar 27, 2024 · 2 comments

Comments

@pohmelie
Copy link

https://github.com/mosquito/aio-pika/blob/master/aio_pika/queue.py#L530
Since there is a non-handled timeout on close call it is possible to suppress original asyncio.CancelledError exception and actually stuck, if caller code will handle TimeoutError.
@Darsstar
Copy link
Contributor

I just refactored #615 a bit so that is should fix this issue.

@LockedThread LockedThread mentioned this issue Apr 25, 2024
Merged
@Darsstar
Copy link
Contributor

fixed in 9.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Darsstar @pohmelie