Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress 'Unexpected connection close' log with RobustConnection #601

Open
Dreamsorcerer opened this issue Nov 20, 2023 · 0 comments
Open

Comments

@Dreamsorcerer
Copy link

When using the robust methods, we get an 'Unexpected connection close' error log when the connection gets interrupted. But, given that it automatically reconnects, we don't need to see this at the error level in our logs.

The log comes from aiormq at:
https://github.com/mosquito/aiormq/blob/2874e58ead567b6c3cdcbbd5c7b4b4e9363ddc0d/aiormq/connection.py#L563-L567

Maybe aio-pika can suppress that log when in RobustConnection? Then possibly add its own logs, maybe an info-level log when the connection drops, and an error-level log if it gives up retrying the connection or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants