MOSIP-31715,MOSIP-31940,MOSIP-31570 #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dhanendra06 <[email protected]>
ase-101
reviewed
Mar 27, 2024
...el-masterdata-service/src/main/java/io/mosip/kernel/masterdata/constant/SchemaErrorCode.java
Show resolved
Hide resolved
ase-101
reviewed
Mar 27, 2024
...terdata-service/src/test/java/io/mosip/kernel/masterdata/test/service/SchemaServiceTest.java
Outdated
Show resolved
Hide resolved
ase-101
requested changes
Mar 27, 2024
...terdata-service/src/test/java/io/mosip/kernel/masterdata/test/service/SchemaServiceTest.java
Outdated
Show resolved
Hide resolved
...terdata-service/src/test/java/io/mosip/kernel/masterdata/test/service/SchemaServiceTest.java
Show resolved
Hide resolved
...terdata-service/src/test/java/io/mosip/kernel/masterdata/test/service/SchemaServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: dhanendra06 <[email protected]>
dhanendra06
commented
Apr 1, 2024
There was a problem hiding this comment.
local build is passing but travis 2 test cases are failing for all the pr.
Error: RegistrationCenterControllerTest.t017deleteRegistrationCenterTest:380 expected: but was:
Error: RegistrationCenterControllerTest.t023decommissionRegCenterFailTest1:522 expected:<KER-MSD-[351]> but was:<KER-MSD-[215]>
Signed-off-by: dhanendra06 <[email protected]>
Signed-off-by: dhanendra06 <[email protected]>
ase-101
approved these changes
Apr 1, 2024
yashmsonkusare
pushed a commit
to yashmsonkusare/admin-services
that referenced
this pull request
Apr 5, 2024
* MOSIP-31715 Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> --------- Signed-off-by: dhanendra06 <[email protected]> Signed-off-by: Yash S <[email protected]>
dhanendra06
added a commit
to dhanendra06/admin-services
that referenced
this pull request
Jun 12, 2024
* MOSIP-31715 Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> --------- Signed-off-by: dhanendra06 <[email protected]>
dhanendra06
added a commit
to dhanendra06/admin-services
that referenced
this pull request
Jun 13, 2024
* MOSIP-31715 Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> * updated the code based on review comments Signed-off-by: dhanendra06 <[email protected]> --------- Signed-off-by: dhanendra06 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.