Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security audit issue in v13.0.0 (@babel/traverse) #401

Open
DmitryMarkov opened this issue Oct 20, 2023 · 4 comments
Open

Security audit issue in v13.0.0 (@babel/traverse) #401

DmitryMarkov opened this issue Oct 20, 2023 · 4 comments

Comments

@DmitryMarkov
Copy link

Kudos @mosch and @dan-lee !
We still use this lib in Cockpit and App ;)

Last week security check thows an issue with one of the deps

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ critical      │ Babel vulnerable to arbitrary code execution when compiling  │
│               │ specifically crafted malicious code                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ @babel/traverse                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=7.23.2                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ react-avatar-editor                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ react-avatar-editor > @babel/plugin-transform-runtime >      │
│               │ babel-plugin-polyfill-corejs2 >                              │
│               │ @babel/helper-define-polyfill-provider > @babel/traverse     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/1094379                     │
└───────────────┴──────────────────────────────────────────────────────────────┘

As I see, you already refactored the lib to not use this dependency, so just want to ask, are you planning to release new stuff any time soon?

@mosch
Copy link
Owner

mosch commented Oct 20, 2023

Hey @DmitryMarkov thank you for bringing this up. I'd be nice to get feedback on the beta, but I think we can release it by now. Let me see...

@mosch
Copy link
Owner

mosch commented Oct 20, 2023

@DmitryMarkov you can try out the 14.0.0-beta.2 and let me know if it works like expected.

@DmitryMarkov
Copy link
Author

@mosch I tried, but at least one functionality isn't working: touch and scroll image inside the area and I see error in console
image
and most critical, it saves black trtansparent image after save
image
🤷‍♂️

@bpinheiroms
Copy link

@DmitryMarkov You can keep with the version 13.
You just need to put this in your package.json: (in my case I'm using PNPM)

"pnpm": {
    "overrides": {
      "@babel/traverse@<7.23.2": ">=7.23.2"
    }
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants