ZMQ build fails on Node V10! Deprecate zmq, and move to zeromq

[shadyvd]

ZMQ does not build on Node V10.x

The owners of the npm module zmq - https://github.com/JustinTulloss/zeromq.node - state:

"This project has moved!

The same people (and more) who brought you zmq now bring you zeromq, under the official zeromq GitHub organization." [sic]

Consider removing the zmq dependency from package.json and adding zeromq: https://www.npmjs.com/package/zeromq

[Emiya0306]

@shadyvd
+1, but I think that it is not enough. Maybe we need to do these two things.

1. zeromq is also using [email protected], so we need to update the nan package of zeromq to the last version.
2. kafka-node version should also be updated to the last version.

[mcollina]

would you like to send a PR? Il giorno gio 31 mag 2018 alle ore 15:02 Roger <[email protected]> ha scritto:

…

@shadyvd <https://github.com/shadyvd> I guess that removing zmq and adding zeromq is not enough. Maybe we need to do these two things. 1. zeromq is also using ***@***.****, so we need to update the *nan* package of zeromq to the last version. 2. kafka-node version should also be updated to the last version. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#188 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL4xODyfxpuTq-CV8F5Xd3JWDeED1Vks5t3-oBgaJpZM4T6_2J> .

[Emiya0306]

En... I forked it and will try. Sorry, I just pick the points I found. 😢

[shadyvd]

There is a circular dependency, as well. Ascoltatori depends on Mosca, which depends on Ascoltatori

I think Mosca needs to be updated first - with the latest version of Ascoltatori as a dependency. Mosca also needs to remove the dependency on hiredis...

@mcollina - any plans of updating Mosca any time soon?

[mcollina]

would you like to send a PR? Il giorno ven 1 giu 2018 alle ore 11:05 Vish Desai <[email protected]> ha scritto:

…

There is a circular dependency, as well. Ascoltatori depends on Mosca <https://github.com/mcollina/mosca>, which depends on Ascoltatori I think Mosca needs to be updated first - with the latest version of Ascoltatori as a dependency. Mosca also needs to remove the dependency on hiredis... @mcollina <https://github.com/mcollina> - any plans of updating Mosca any time soon? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#188 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL49BDE-OYo1zSv-A8RoNqxzIZFDs7ks5t4QPGgaJpZM4T6_2J> .

[shadyvd]

Apologies it took me this long to get around to this - I believe this is done now.

ZeroMQ has updated its dependency on Nan, so that is taken care of. Upgrading to the latest Kafka library, unfortunately, breaks things. I'll try and take a crack at it in a few days.