[question] does the test "unsubscribe throws error" valid?

[gnought]

aedes/test/client-pub-sub.js

Lines 664 to 688 in bba422b

	test('unsubscribe throws error', function (t) {
	t.plan(2)
	const broker = aedes()
	t.teardown(broker.close.bind(broker))
	broker.on('client', function (client) {
	client.subscribe({
	topic: 'hello',
	qos: 0
	}, function (err) {
	t.error(err, 'no error')
	broker.unsubscribe = function (topic, func, done) {
	done(new Error('error'))
	}
	client.unsubscribe({
	topic: 'hello',
	qos: 0
	}, function () {
	t.pass('throws error')
	})
	})
	})
	connect(setup(broker))
	})

The mocked broker.unsubscribe is only called by broker.close.

1. Does it expect to be called by client.subscribe ?
2. The Error does not be raised in client error event. Bug?
3. The callback in client.subscribe does not contain any error argument, does the message in t.pass make sense?

[robertsLando]

By reading it makes no sense to me too. I think it should be something like:

client.unsubscribe({ 
         topic: 'hello', 
         qos: 0 
       }, function (err) { 
         t.equal(err.message, 'error', 'throws error') 
       }) 

[gnought]

@robertsLando so do I, however the callback call doesn't have err parameter.

[robertsLando]

I should try it so, I dunno sincerly... let me know if you fix it