Support ShareGPT chat format #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextrott16
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
My heart says this is all correct and good, but recommend getting the final green light from @dakinggg.
|
tests please :) specifically some unit tests testing that having a tool role gets processed the way you think it does, and ideally a sample training run on the open hermes dataset |
|
I was teaming up with Sam on this. The run |
dakinggg
approved these changes
Apr 11, 2024
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
This adds support for the other common chat format. We just remap keys and add a new role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the other common chat format. We just remap keys and add a new role.