From d1d75cb8b2608e7168215bff2aa1adddae7b05e7 Mon Sep 17 00:00:00 2001 From: Anna Pfohl Date: Thu, 4 Jan 2024 19:44:00 +0000 Subject: [PATCH] fighting with docstrings --- llmfoundry/callbacks/async_eval_callback.py | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/llmfoundry/callbacks/async_eval_callback.py b/llmfoundry/callbacks/async_eval_callback.py index 3ebd11cacb..c292243e52 100644 --- a/llmfoundry/callbacks/async_eval_callback.py +++ b/llmfoundry/callbacks/async_eval_callback.py @@ -250,14 +250,13 @@ def __init__( log.info('Initialized AsyncEval callback. Will generate runs at ' + f'interval {interval}, checking at {self.check_interval}') + @staticmethod def _get_ready_sharded_checkpoints( - self, checkpointer_checkpoints: List[str], remote_files: List[str], ): - """ - Determine which checkpoints from the checkpointer are ready to be evaled, - based on which shards have been uploaded to the remote checkpoint folder. + """Identify checkpoints are ready to be evaled based on remote files + This has special logic for sharded checkpoints to consider checkpoints composed of multiple shards (one per gpu) and metadata @@ -294,15 +293,14 @@ def _get_ready_sharded_checkpoints( return checkpoints_to_eval + @staticmethod def _get_ready_single_checkpoints( - self, checkpointer_checkpoints: List[str], remote_checkpoints: List[str], ): - """ - Determine which checkpoints from the checkpointer are ready to be evaled, - based on which checkpoints have been uploaded. This is much simpler than - the sharded case, because there is only one file + """Identify checkpoints are ready to be evaled based on remote checkpoints + + This is much simpler than the sharded case, because there is only one file Args: checkpointer_checkpoints: The checkpoints from the checkpointer state