From 3b48acecf5073280508bf61635fa198317911215 Mon Sep 17 00:00:00 2001
From: Sanjari Srivastava <sanjari@orby.ai>
Date: Wed, 12 Jun 2024 16:32:18 -0700
Subject: [PATCH] nits

---
 llmfoundry/registry.py                          | 5 ++++-
 tests/eval/test_in_context_learning_datasets.py | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/llmfoundry/registry.py b/llmfoundry/registry.py
index 3f754e1952..6f6b2a2d57 100644
--- a/llmfoundry/registry.py
+++ b/llmfoundry/registry.py
@@ -212,7 +212,10 @@
 icl_datasets = create_registry(
     'llmfoundry',
     'icl_datasets',
-    # TODO: Change type to InContextLearningDataset
+    # TODO: Change type from Dataset to
+    # llmfoundry.eval.InContextLearningDataset.
+    # Using ICL dataset here introduces a circular import dependency between
+    # the registry and eval packages right now, thus needs some refactoring.
     generic_type=Type[Dataset],
     entry_points=True,
     description=_icl_datasets_description,
diff --git a/tests/eval/test_in_context_learning_datasets.py b/tests/eval/test_in_context_learning_datasets.py
index c17f3a135c..3182005b58 100644
--- a/tests/eval/test_in_context_learning_datasets.py
+++ b/tests/eval/test_in_context_learning_datasets.py
@@ -2272,7 +2272,7 @@ def test_qa_task_evaluation(
             'pad_tok_id': tokenizer.eos_token_id,
             'num_fewshot': num_fewshot,
             'prompt_string': '',
-            'example_delimite': '\n',
+            'example_delimiter': '\n',
             'continuation_delimiter': ': ',
         }
     )