Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing comment in the deeplabv3.yaml #59

Open
Godofnothing opened this issue Dec 29, 2022 · 1 comment
Open

Confusing comment in the deeplabv3.yaml #59

Godofnothing opened this issue Dec 29, 2022 · 1 comment
Assignees

Comments

@Godofnothing
Copy link

In the example of deeplab training in the yaml config file deeplab/yamls/deeplabv3.yaml it is written in config file:

batch_size: 128                    # Training dataloader batch size per device - line 26
batch_size: 128                    # Evaluation dataloader batch size per device - line 39

But, according to the main.py (lines 64-66) it should be not the batch size per device rather the total batch size.

if dist.get_world_size():
    train_batch_size //= dist.get_world_size()
    eval_batch_size //= dist.get_world_size()
@Landanjs
Copy link
Contributor

Yes, that comment is incorrect. batch_size is the total batch size not per device batch size. We will fix it ASAP, thank you for the notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants