Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaining several chain_callbacks in an overlay #789

Open
cehberlin opened this issue Mar 14, 2018 · 0 comments
Open

Chaining several chain_callbacks in an overlay #789

cehberlin opened this issue Mar 14, 2018 · 0 comments

Comments

@cehberlin
Copy link
Contributor

Hi,
the following two lines are questionable in my opinion.

self.on_completion(result)

I am not sure if calling self.on_completion() in the chain_callback is correct. Why this is necessary? From my understanding the chain_callback can be used to trigger something when a service is completed. For this reason the function AbstractObject.completed() is checking on_completion. But why this is repeated in the executed chain_callback? The problem that I am in particular facing is, that this prevents to chain several chain_callbacks after each other or in other words chain several service calls after each other.

I have solved this for my use case by overwriting def _chain_callback in my overlay but just wanted to raise this issue to check if this might be a problem in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant