Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create variable backdrop #113

Closed
lastmeta opened this issue Jan 6, 2022 · 2 comments
Closed

create variable backdrop #113

lastmeta opened this issue Jan 6, 2022 · 2 comments
Assignees
Labels
Task Additions: Brand new tasks -- New story tasks etc.

Comments

@lastmeta
Copy link
Collaborator

lastmeta commented Jan 6, 2022

Describe The Task

For various pages we have a larger header on the backlayer. This poses a challenge since the "page" is confined to the front layer.

I've thought of two ways to handle this.

  1. we could make a backlayer widget which wraps the nav drawer and whatever else we might need (balance/send/transaction) and depending on the route it could show what we want it to show. We'd also have to make the front layer drop a variable amount.
  2. we could make the main page have a regular scaffold on it rather than a backdropscaffold. then on individual pages we could make a backdrop scaffold without an app bar.

We've nested scaffolds before without issue, but it is bad practice, and we're already setup for 1 so I'm going to try that one first.

Additional Context

this structure will support #110

@lastmeta lastmeta added the Task Additions: Brand new tasks -- New story tasks etc. label Jan 6, 2022
@lastmeta lastmeta self-assigned this Jan 6, 2022
@lastmeta
Copy link
Collaborator Author

lastmeta commented Jan 6, 2022

option one seems pretty manageable, I can automatically reveal a variable amount of the back layer on going to any page, and I can display anything on the backlayer I want per page. But, there's something we'll have to fix -

Backdrop.of(components.navigator.routeContext!).revealBackLayer();

this funciton applies a scrim to the front layer and if you click the front layer it automatically hides the back layer. This is not what we want on the Send, or Transactions pages. we only want that on the home page where we're hiding the nav drawer. soo... I'll probably have to make a sister function to that one without the gesture detector or the scrim. Once I can do that option number 1 will be proven to be sufficient for our needs I think.

And besides, even if we went with option 2, we'd have to make that ability anyway.

@lastmeta
Copy link
Collaborator Author

lastmeta commented Jan 6, 2022

lastmeta added a commit that referenced this issue Jan 6, 2022
@lastmeta lastmeta closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Additions: Brand new tasks -- New story tasks etc.
Projects
None yet
Development

No branches or pull requests

1 participant