-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support collators in starlight #664
Conversation
Coverage Report@@ Coverage Diff @@
## master tomasz-wip-solochain-tanssi-node +/- ##
====================================================================
- Coverage 70.37% 69.85% -0.52%
Files 264 264
+ Lines 48037 48404 +367
====================================================================
+ Hits 33805 33811 +6
+ Misses 14232 14593 +361
|
I general this PR is as good as it can be for now. There is work to be done on the node-side, but that is planned for another PR. @tmpolaczyk let's fix the small things, and let's see what the rest has to say |
f2cb139
to
9b2d5cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's an approval for me, but I want more eyes on it @ParthDesai @nanocryk @Agusrodri
Allow collators to connect to starlight using
tanssi-node
binary, and create blocks for container chains there.Can be tested with
pnpm moonwall run zombie_tanssi_relay
.List of hacks:
In zombienet, collators are spawned as nodes connected to container 2000. This makes it easier to spawn the nodes because zombienet automatically injects all the args. So in tanssi-node, the "orchestrator_client" is not an orchestrator client, but a parachain template client. This is nice because then it will fail if we try to use it for orchestrator stuff, but it would be better if there was no client at all. I removed the "start_network" function so I believe collators will never connect to parachain 2000, it would be nice to remove more stuff.
parathreads not supported because it's missing the buy_core function
all runtime apis called through the RelayChainInterface must be hardcoded, so we won't get a compile error if we put the wrong input or output type