We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The default label in Button breaks backwards compatibility in classes that specialize Button. For example, take the following:
var Button = require("montage/ui/button.reel").Button; exports.ActionButton = Button.specialize(/** @lends ActionButton.prototype */ {
With this commit "Button" is shoehorned into the element as seen below.
A quick fix on our end is to define empty label and defaultLabel properties in the Child class
label
defaultLabel
var Button = require("montage/ui/button.reel").Button; exports.ActionButton = Button.specialize(/** @lends ActionButton.prototype */ { defaultLabel: { value: "" }, label: { value: "" },
However, the label is a breaking change if it is released and changes are not made in the implementing application.
For context, the use case for specializing button is two-fold:
The text was updated successfully, but these errors were encountered:
@marchant FYI
Sorry, something went wrong.
thibaultzanini
No branches or pull requests
The default label in Button breaks backwards compatibility in classes that specialize Button. For example, take the following:
With this commit "Button" is shoehorned into the element as seen below.
A quick fix on our end is to define empty
label
anddefaultLabel
properties in the Child classHowever, the label is a breaking change if it is released and changes are not made in the implementing application.
For context, the use case for specializing button is two-fold:
The text was updated successfully, but these errors were encountered: