-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS SecretsManager Connector #562
Comments
Yeah, and why not! :) Would it be a wrapper on top of the aws client? In that case I would just ask that the connector follows the api design of the Would be also good if we also expose overloaded methods that also not requires to create the java objects with builders and so on, like if you want to perform a
or like:
|
Its a wrapper on top of the aws client like s3, so much so that a lot of the code is mimicked between the two. Calling to get a secret looks like this:
or
where runnerIO is my scheduler. But yeah there are some overloaded methods that I've had a weird time dealing with (just chose which one to use basically), so the describeRequest example sounds like a good idea to avoid that and I'll have those built ins. |
that looks good! :) |
So I have created, delete, update, and listSecrets. Is this enough functionality for an initial pull request or should I wait until I have all of it? |
You can create a WIP pull request if u prefer it |
How would y'all feel about a AWS SecretsManager Connector? I'm pretty close to having the basic functionally finished for it (created, delete, update, list) and I'll add IT test for those as well.
The text was updated successfully, but these errors were encountered: