-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOOLS-3271 Import Time-Series Collections via mongoimport #535
Open
themattman
wants to merge
19
commits into
mongodb:master
Choose a base branch
from
themattman:matt.kneiser/skunk-import-ts-collections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TOOLS-3271 Import Time-Series Collections via mongoimport #535
themattman
wants to merge
19
commits into
mongodb:master
from
themattman:matt.kneiser/skunk-import-ts-collections
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds support in
mongoimport
for importing data from CSV & TSV directly into a time-series collection.Today,
mongoimport
can import data into an existing time-series collection, only if it was already created correctly prior to runningmongoimport
. However, if there are any issues with the schema, the user will see one error per document. This improvement will fail immediately before trying to insert data so the user can more quickly resolve issues.How
createCollection
with the user-provided time-series options before inserting.date
via--fields
,--fieldFile
, or--headerline
.auto
type is not allowed because adate
type cannot be coerced.date
type will fail on insert, so failing validation prior to insertion is more user-friendly.--columnsHaveTypes
is therefore required.API Changes
Four new parameters added:
--timeSeriesTimeField=<column_name>
--timeSeriesMetaField=<column_name>
--timeSeriesGranularity=[seconds(default),minutes,hours]
--timeSeriesExists=[false(default), true]
How Tested
Standalone
ReplicaSet
Sharded Cluster
Known Issues
Documents are inserted unordered. I've seen this with the Python driver,
pymongo
, when not usingOrderedDict
. The Go driver appears to use the orderedbson.D
and not unorderedbson.M
, so this is confusing behavior.