LG-4681: fix row background-color styles #2560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stephl3
commented
Nov 27, 2024
| [disabledStyles[theme]]: disabled, | ||
| [clickableStyles[theme]]: !!onClick, | ||
| }, | ||
| className={getRowBaseStyles({ | ||
| className, | ||
| )} | ||
| isClickable: !!onClick, | ||
| isDisabled: disabled, |
There was a problem hiding this comment.
The disabled and clickable styles don't conflict with each other anyways but wanted to explicitly call out that I swapped the order of these in getRowBaseStyles: https://github.com/mongodb/leafygreen-ui/pull/2560/files#diff-cdea201e57c6a1377cfb33f54cfae6a9bb1baefe734a008b505babcbee0ea78aR45-R46
The new ordering seemed more appropriate. Please let me know if otherwise and I can revert this
| [getGrayZebraRowStyles(theme)]: | ||
| isOddVSRow && shouldAlternateRowColor && !isSelected, | ||
| [getSelectedRowStyles(theme)]: isSelected && !isDisabled, | ||
| [getExpandedContentParentStyles(theme)]: isExpanded, |
There was a problem hiding this comment.
not entirely clear how this fixed it but switching expandedContentParentStyles to the function getExpandedContentParentStyles enabled this to work!
There was a problem hiding this comment.
I'm not seeing alternative row styles https://642700aa3e49e32bdbf0b0fc-pnljhcjlas.chromatic.com/?path=/story/components-table-with-virtualized-scrolling--basic
There was a problem hiding this comment.
ahh I must have been cached in a weird state. I tried pushing up a new change that I think actually fixes it now
|
Size Change: +74 B (+0.01%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Refactors row styles and somehow fixes the styling issue (unclear what actually fixed it... 🙃)
🎟 Jira ticket: LG-4681
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes🧪 How to test changes
Table/RowTable/WithVirtualizedScrolling