Table types r17
#2558
Open
Table types r17
#2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: -130 B (-0.01%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
shaneeza
requested review from
tsck and
TheSonOfThomp
and removed request for
a team
Comment on lines
+22
to
+23
| * // @ts-expect-error | ||
| * Row.propTypes = {}; |
There was a problem hiding this comment.
I think this might fail if someone tries to use styled(Row)
There was a problem hiding this comment.
I'm testing styled in each component spec file, and I also tested a styled component story in storybook; it seems to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
My initial solution worked in R18 but failed in R17 when a generic forward and generic memo were combined. This is a new reusable implementation.
In this PR
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes