Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-6170): update release please owner #35

Merged
merged 2 commits into from
Jun 4, 2024
Merged

chore(NODE-6170): update release please owner #35

merged 2 commits into from
Jun 4, 2024

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • update release please owner
  • make highlight use fetch and remove octokit
Is there new documentation needed for these changes?

What is the motivation for this change?

  • new source for release please
  • using fetch and "repository" variable makes copy pasting to other repos easier because there's now no owner/repo varaibles in the script that has to be changed.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review May 23, 2024 15:53
@nbbeeken nbbeeken requested a review from baileympearson June 3, 2024 19:15
baileympearson
baileympearson requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we're not removing Oktokit as a dependency from mongodb-legacy, like we did in other repos?

@nbbeeken nbbeeken requested a review from baileympearson June 4, 2024 19:46
@nbbeeken
Copy link
Collaborator Author

nbbeeken commented Jun 4, 2024

An oversight, updated

@baileympearson baileympearson merged commit cb63628 into main Jun 4, 2024
8 checks passed
@baileympearson baileympearson deleted the NODE-6170-release-please-owner branch June 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson