Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links don't open in new tabs #1921

Open
konstantinosfragkoulis opened this issue Jan 28, 2022 · 3 comments · May be fixed by #2379 or #2381
Open

Links don't open in new tabs #1921

konstantinosfragkoulis opened this issue Jan 28, 2022 · 3 comments · May be fixed by #2379 or #2381
Labels
enhancement New feature or request

Comments

@konstantinosfragkoulis
Copy link

On the website there are many links which have next to them the symbol that indicates that they will open in a new tab but they don't
Screenshot from 2022-01-28 10-13-18
.

@erciccione erciccione added the enhancement New feature or request label Jan 30, 2022
@erciccione
Copy link
Contributor

The symbol is to warn the user that they are about to click on an external link. Meaning they will leave getmonero for an external website, it's not meant to signal that a new tab will be open.

Either way, i'm ok with #1922, which makes external links open in a new tab.

@FedericoNembrini
Copy link

I saw that pull request #1922 has been closed, maybe I can take care of that.

From what I've read, target="_blank" should be added to all <a /> that lead to sites other than this one (or rather, those to which this style a[href^="https:"]:not([href*="getmonero.org"]) is applied).

The resource files in the _i18n/ directory shouldn't be modified, right?

@erciccione
Copy link
Contributor

@FedericoNembrini that would be appreciated, thanks :)

The resource files in the _i18n/ directory shouldn't be modified, right?

Only the english files should be edited (en folder and en.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants