-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates K8s security checks #273
Conversation
This comment has been minimized.
This comment has been minimized.
updates spelling Signed-off-by: Scott Ford <[email protected]>
c7de51d
to
ac31e8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great addition @scottford-io ! It goes a long way making our policies more clean.
Hope the comments help.
Signed-off-by: Scott Ford <[email protected]>
@mm-weber all recommendations have been added. Thank you for the great review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a pretty major overhaul of the K8S security policy checks. This PR uses the most current style of check writing to ensure checks return "clear, accurate, and actionable" results.
Current Method Example: Container should not allow privilege escalation
The current check is written as follows:
While the check does make an assertion, the results return data.
Updated Method: Container should not allow privilege escalation
This PR updates the check as follows:
The results from a passing check look like this:
The results from failed check will return the following: