Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 make sure gitlab discovers only unique assets #3392

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

imilchev
Copy link
Member

It is possible to setup gitlab in such a way that 1 project appears in multiple groups. The gitlab provider discovers assets starting from the root and traversing down finding everything along the way. It is possible that the same thing is found in 2 different places. In the end the provider should return a unique list of assets with no duplicates to make sure everything works as expected

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imilchev

Copy link
Contributor

Test Results

2 804 tests  ±0   2 803 ✅ ±0   54s ⏱️ -7s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 986cab8. ± Comparison against base commit 1cab39c.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-21_13:45:24.751704917_+0000_UTC_m=+0.064006569
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_13:45:24.751704917_+0000_UTC_m=+0.064006569
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_13:45:24.751704917_+0000_UTC_m=+0.064006569#01
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-21_12:27:35.040447084_+0000_UTC_m=+0.007676064
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_12:27:35.040447084_+0000_UTC_m=+0.007676064
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_12:27:35.040447084_+0000_UTC_m=+0.007676064#01

@imilchev imilchev merged commit 0fd688a into main Feb 21, 2024
14 checks passed
@imilchev imilchev deleted the ivan/gitlab-discovery-duplicates branch February 21, 2024 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants