-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Include version in origin field for debian packages #3426
Conversation
An exmaple:
|
1c73764
to
d75c312
Compare
Some packages contain the version information for the source package. Where we can find it, we add it. Signed-off-by: Christian Zunker <[email protected]>
d75c312
to
357468d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comment about the MQL resource. Do we also need to adjust other operating systems that have origin support or is that just debian?
providers/os/resources/os.lr
Outdated
@@ -616,6 +616,9 @@ package @defaults("name version") { | |||
|
|||
// Package origin (optional) | |||
origin() string | |||
// Package origin version (optional) | |||
originVersion() string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be origin package that references another full package? We have the following options:
// dict returns name and version field
originPackage() dict
// return full package resource
originPackage() package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discuessed, I now include the version in the origin field as it is shown in dpkg output:
samba (2:4.17.12+dfsg-0+deb12u1)
I checked Alpine. That does not provide a version, only the origin name. |
Signed-off-by: Christian Zunker <[email protected]>
3fdeba2
to
1843f11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @czunker
Signed-off-by: Christian Zunker <[email protected]>
Co-authored-by: Christoph Hartmann <[email protected]>
Some packages contain the version information for the source package. Where we can find it, we add it.