New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS/GCP snapshot cleanup isn't working with builtin providers #2190

Closed

czunker opened this issue Oct 12, 2023 · 1 comment

Labels

Contributor

czunker commented Oct 12, 2023

Describe the bug
While debugging #2171 with builtin providers, I noticed that cleanup is not happening.

For ebs and gcp snapshot scanning, we call some cleanup after the scan is done. This cleanup is triggered via the provider shutdown. But builtin providers are added to the running providers, so they aren't shut down later:
https://github.com/mondoohq/cnquery/blob/main/providers/coordinator.go#L107-L117

This makes debugging harder.

To Reproduce
Steps to reproduce the behavior:

Run a GCP or EBS snapshot scan with builtin providers for aws/gcp and os.
Notice the scan finishing
Note that the cloud console still shows created volumes and mountpoints are still present in the VM

Expected behavior
We should be able to execute this cleanup also with builtin providers.

czunker mentioned this issue

ebs scan failing with describe instances missing region error #2158

Closed

chris-rock added the snapshot label

Member

imilchev commented Mar 1, 2024

this should now work with the new disconnect logic

imilchev closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment