Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different mapping options #97

Open
kothique opened this issue May 10, 2019 · 2 comments
Open

Different mapping options #97

kothique opened this issue May 10, 2019 · 2 comments
Assignees

Comments

@kothique
Copy link
Collaborator

kothique commented May 10, 2019

sensor.initialize({
  // ... options along the way,
  mapping: 'physical' // 'gpio', 'bcm', 'wiringPi' could be supported for example (bcm === gpio)
});

The default option would be 'gpio' for compatibility.
Also I don't know if it should be done on JS or C++ side.

@momenso
Copy link
Owner

momenso commented May 11, 2019

I like the idea. I'd prefer to have the mapping done in the JS layer. I'd like to avoid growing the C/C++ layer unless there's a good reason for it (e.g. performance, low-level GPIO access, etc).

@kothique
Copy link
Collaborator Author

Agreed.

@kothique kothique self-assigned this May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants