Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions to the JTB part #55

Open
MarcMazas opened this issue Sep 20, 2023 · 4 comments
Open

Contributions to the JTB part #55

MarcMazas opened this issue Sep 20, 2023 · 4 comments

Comments

@MarcMazas
Copy link

Hi.
I'm the maintainer of JTB since JTB 1.4.0, which now is at 1.5.1. See https://github.com/jtb-javacc/JTB.
I plan to update the JTB distribution at Maven Central (https://central.sonatype.com/artifact/edu.purdue.cs/jtb).
I just saw that your javacc maven plugin has some features for handling JTB, but for the very old versions.
Would you like me to contribute to your maven plugin on the JTB part, or do you prefer I create and release a new dedicated plugin?
TIA.Marc

@slawekjaranowski
Copy link
Member

@MarcMazas - thanks for helping. Contributions are welcome.

As I see plugins is used in many places - https://github.com/mojohaus/javacc-maven-plugin/network/dependents

So I think better will be improve it rather that introduce one new.

Please mention me on PR, I will try to help with merge and next release.

@MarcMazas
Copy link
Author

OK.
Do you have coding standards? E.g.: formatting, javadoc, errors/warnings settings, unused variables, static use...

@slawekjaranowski
Copy link
Member

For code formatting I will enable spotles in project and will be done automaticaly.

As this is a Maven plugin some of information can be read here:
https://maven.apache.org/plugin-developers/index.html

if possible I would like to not use a static variable - it can introduce concurrency problems in multithread builds.
But each needed can be specific and we can discuss on examples.

@slawekjaranowski
Copy link
Member

spotless #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants