Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hds.get_kstpkper() returns 0 based kstp,kper while hds.kstpkper returns one based. #1338

Closed
RyanConway91 opened this issue Jan 26, 2022 · 1 comment
Closed

hds.get_kstpkper() returns 0 based kstp,kper while hds.kstpkper returns one based. #1338

RyanConway91 opened this issue Jan 26, 2022 · 1 comment
Assignees
@jdhughes-usgs @wpbonelli

Comments

@RyanConway91
Copy link

hds.get_kstpkper() returns 0 based kstp,kper while hds.kstpkper returns one based.
hds = fp.utils.binaryfile.HeadFile(r"my.hds")

Is there a good reason for this? If not I would think both should be 0 based like most other stuff in flopy?
@jdhughes-usgs jdhughes-usgs self-assigned this Jul 19, 2022
@jdhughes-usgs jdhughes-usgs added this to the 3.3.6 milestone Jul 19, 2022
@mwtoews mwtoews modified the milestones: 3.3.6, 3.5.0 Jul 27, 2023
@wpbonelli wpbonelli self-assigned this Nov 13, 2023
@wpbonelli wpbonelli mentioned this issue Nov 13, 2023
Merged
@wpbonelli
Copy link
Member

wpbonelli commented Nov 22, 2023 •
edited
Loading

Discussed briefly in #2000, may eventually consider deprecating 1-based indexed attributes more comprehensively, for now just clarified the docstrings

@wpbonelli wpbonelli modified the milestones: 3.5.0, 3.7.0 Mar 2, 2024
@wpbonelli wpbonelli removed this from the 3.7.0 milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdhughes-usgs jdhughes-usgs

@wpbonelli wpbonelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mwtoews @jdhughes-usgs @wpbonelli @RyanConway91