-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed when #3532
Detailed when #3532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to other suggestions, I'd like to get rid of this non-normative text, now that we have clearly defined that it is not allowed:
\begin{nonnormative}
Comment: The semantics are undefined if the function call of an
impure function is part of an algebraic loop.
\end{nonnormative}
Phone meeting: If we want to have names:
|
Co-authored-by: Henrik Tidefelt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The request to remove obsolete text in #3532 (review) is still not addressed. Apart from that, it looks OK.
Co-authored-by: Henrik Tidefelt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as last time:
The request to remove obsolete text in #3532 (review) is still not addressed. Apart from that, it looks OK.
If there is a reason why this text shouldn't be considered obsolete, please explain.
There are several reasons to keep that:
|
Pinging for reviews after holidays. |
It is related to this PR, as this PR is introducing this rule that looks crystal clear to me:
|
I have opened a different PR #3571 to clarify that, since as previously stated it is an unrelated issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking with the initialization team for any feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall. Just requesting a typo fix.
Co-authored-by: Elena Shmoylova <[email protected]>
Other text is part of a separate PR
Closes #3499
Closes #3498