Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out niche value computation #2368

Closed
wants to merge 1 commit into from
Closed

Factor out niche value computation #2368

wants to merge 1 commit into from

Conversation

tautschnig
Copy link
Member

Description of changes:

There will be future re-use of this code, so move it to a public function.

Resolved issues:

n/a

Related RFC:

n/a

Call-outs:

n/a

Testing:

  • How is this change tested? Used in existing tests (in CI).

  • Is this a refactor change? Yes.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

There will be future re-use of this code, so move it to a public
function.
@tautschnig tautschnig requested a review from a team as a code owner April 13, 2023 10:33
@tautschnig tautschnig mentioned this pull request Apr 13, 2023
4 tasks
@tautschnig
Copy link
Member Author

Closing in favour of #2369, which is backed by a branch in my own fork.

@tautschnig tautschnig closed this Apr 13, 2023
@celinval celinval deleted the niche-value branch April 13, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant