From 3ba98bbfbad30401f2f3ebf8ca8719092a0107b3 Mon Sep 17 00:00:00 2001 From: Erik Bernhardsson Date: Tue, 19 Nov 2024 13:48:38 +0000 Subject: [PATCH 1/2] Remove single_object_id from AppSetObjects --- modal_proto/api.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modal_proto/api.proto b/modal_proto/api.proto index 377ec7472..59b8a17f9 100644 --- a/modal_proto/api.proto +++ b/modal_proto/api.proto @@ -427,7 +427,7 @@ message AppSetObjectsRequest { string client_id = 3; repeated string unindexed_object_ids = 4; AppState new_app_state = 5; // promotes an app from initializing to this new state - string single_object_id = 6; + reserved 6; } message AppStopRequest { From db5ff17439d955d08a79fbe2fe7e1315babc0fe0 Mon Sep 17 00:00:00 2001 From: Erik Bernhardsson Date: Tue, 19 Nov 2024 13:53:04 +0000 Subject: [PATCH 2/2] Fix test --- test/conftest.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/conftest.py b/test/conftest.py index b229fcbce..af7863d11 100644 --- a/test/conftest.py +++ b/test/conftest.py @@ -152,7 +152,6 @@ def __init__(self, blob_host, blobs, credentials): } ] self.app_objects = {} - self.app_single_objects = {} self.app_unindexed_objects = { "ap-1": ["im-1", "vo-1"], } @@ -485,8 +484,6 @@ async def AppSetObjects(self, stream): request: api_pb2.AppSetObjectsRequest = await stream.recv_message() self.app_objects[request.app_id] = dict(request.indexed_object_ids) self.app_unindexed_objects[request.app_id] = list(request.unindexed_object_ids) - if request.single_object_id: - self.app_single_objects[request.app_id] = request.single_object_id self.app_set_objects_count += 1 if request.new_app_state: self.app_state_history[request.app_id].append(request.new_app_state)