Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve minimalWindSea definition #20

Open
mochell opened this issue Mar 11, 2024 · 0 comments
Open

improve minimalWindSea definition #20

mochell opened this issue Mar 11, 2024 · 0 comments
Labels
invalid This doesn't seem right

Comments

@mochell
Copy link
Owner

mochell commented Mar 11, 2024

change from
get_minimal_windsea(u10, v10, DT)
MinimalParticle(u10, v10, DT)
to
get_minimal_windsea(DT, u10::Number=0, v10::Number::0)
MinimalParticle(DT,u10::Number=0, v10::Number::0)

such that it can just be called with get_minimal_windsea(DT) internally,
remove explicit required definition from PW.ODESettings, WaveGrowthModels2D.WaveGrowth2D
@mochell mochell added the invalid This doesn't seem right label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mochell