Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error with code generation when file has unnamed extension #1020

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: error with code generation when file has unnamed extension #1020

merged 2 commits into from
Oct 31, 2024

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Oct 26, 2024 •
edited
Loading

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Fixes #1010

Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@amondnet amondnet self-assigned this Oct 26, 2024
@amondnet amondnet marked this pull request as draft October 26, 2024 05:53
@amondnet amondnet added the bug Something isn't working label Oct 26, 2024
@amondnet amondnet force-pushed the gh-1010 branch 2 times, most recently from 09f99a7 to a324c77 Compare October 26, 2024 06:27
@amondnet amondnet marked this pull request as ready for review October 26, 2024 07:21
@amondnet amondnet marked this pull request as draft October 26, 2024 07:21
@amondnet amondnet marked this pull request as ready for review October 30, 2024 18:59
@amondnet
Copy link
Collaborator Author

@pavanpodila @fzyzcjy Could you please review the code?

@amondnet amondnet force-pushed the gh-1010 branch 3 times, most recently from 6311dea to 1dce534 Compare October 30, 2024 19:16
@pavanpodila pavanpodila merged commit b5ab10e into mobxjs:main Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavanpodila pavanpodila pavanpodila approved these changes

@fzyzcjy fzyzcjy Awaiting requested review from fzyzcjy

Assignees

@amondnet amondnet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mobx_codegen] error with code generation when file has unnamed extension
2 participants
@amondnet @pavanpodila