From ef3458112d61acf5210540f3823beae93f282794 Mon Sep 17 00:00:00 2001 From: Minsu Lee Date: Sat, 25 Nov 2023 15:09:12 +0900 Subject: [PATCH] fix: `ObservableSet` and `ObservableMap` should not notify all listeners when `observe` with fireImmediately --- .github/workflows/build.yml | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c4df82f3..d172a20c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -72,8 +72,13 @@ jobs: build_lint_packages: runs-on: ubuntu-latest + defaults: + run: + working-directory: ${{ matrix.package }} + strategy: matrix: + package: ["mobx_lint", "mobx_lint_flutter"] version: ["stable"] steps: @@ -81,18 +86,30 @@ jobs: - uses: subosito/flutter-action@v2 with: channel: ${{ matrix.channel }} - + - name: Add pub cache bin to PATH + run: echo "$HOME/.pub-cache/bin" >> $GITHUB_PATH + - name: Add pub cache to PATH + run: echo "PUB_CACHE="$HOME/.pub-cache"" >> $GITHUB_ENV - name: Install dependencies - working-directory: mobx_lint - run: dart pub get + run: flutter pub get + - run: dart pub global activate custom_lint - name: Analyze - working-directory: mobx_lint - run: dart analyze --fatal-warnings --fatal-infos . + run: flutter analyze + + - name: Run custom_lint + run: custom_lint + # Workaround to https://github.com/invertase/dart_custom_lint/issues/77 + if: matrix.package == 'mobx_lint_flutter_test' - name: Run tests - working-directory: mobx_lint_flutter_test - run: | - flutter pub get - flutter test test + if: matrix.package == 'mobx_lint_flutter_test' + run: flutter test --coverage --coverage-path coverage/lcov.txt + - name: Upload coverage to codecov + uses: codecov/codecov-action@v3 + if: matrix.package == 'mobx_lint_flutter_test' + with: + token: ${{ secrets.CODECOV_TOKEN }} + flags: mobx_lint + files: coverage/lcov.txt \ No newline at end of file