Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for interactive registration #411

Open
K-Meech opened this issue Aug 12, 2021 · 10 comments
Open

Add support for interactive registration #411

K-Meech opened this issue Aug 12, 2021 · 10 comments

Comments

@K-Meech
Copy link
Collaborator

K-Meech commented Aug 12, 2021

It would be great to support different registration methods in MoBIE e.g.

  • manual registration
  • bigwarp
  • elastix
@constantinpape
Copy link
Contributor

Potentially related issue: mobie/mobie.github.io#32

@tischi
Copy link
Contributor

tischi commented Jan 19, 2022

@NicoKiaru
What's the status of the BigWarp integration with BDV-Playground?
Could we just enable it in MoBIE?
If so, could you point me to the relevant code to do so?

@tischi
Copy link
Contributor

tischi commented Jan 20, 2022

@NicoKiaru Thanks a lot!
This is the output, right?

BigWarpLauncher bwl = new BigWarpLauncher(movingSacs, fixedSacs, bigwarpname, converterSetups);
// ...   
// Output
gridsource = bwl.getGridSource();
warpmagnitudesource = bwl.getWarpMagnitudeSource();
warpedsources = bwl.getWarpedSources();

Is there some way to only enable affine transform (or only rigid) registration in bigWarp and then get back the affine transform?

In fact, in my use-case the movingSacs are TransformedSource already and I think it would be OK if their sourceTransform was directly modified by the registration.

@NicoKiaru
Copy link

In fact, in my use-case the movingSacs are TransformedSource already and I think it would be OK if their sourceTransform was directly modified by the registration.

Yes then you can probably get the transformed source, get its transform, and build a new Transformed source out of it ?

@tischi
Copy link
Contributor

tischi commented Jan 21, 2022

@NicoKiaru
What is this doing?

		// Output bdvh handles -> will be put in the object service
		bdvhq = bigWarpLauncher.getBdvHandleQ();
		bdvhp = bigWarpLauncher.getBdvHandleP();

		bdvDisplayService.pairClosing(bdvhq, bdvhp);

@tischi
Copy link
Contributor

tischi commented Jan 21, 2022

Wohoooo!

image

@NicoKiaru @bogovicj Amazing! Took me just ~45 minutes to make BigWarp work in MoBIE 🥳
@martinschorb @constantinpape

@tischi
Copy link
Contributor

tischi commented Jan 21, 2022

@bogovicj what would be cool now would be a way for the user to "Cancel" in a way that MoBIE knows that it should not apply the transformation and revert back to the original SourceTransform.
So, I would need something in BigWarp that says "Cancel" and that I could listen to.
Or, I guess we could have an own little window pop up in MoBIE with two buttons: "Apply transform in MoBIE" and "Cancel". What do you think?

@tischi
Copy link
Contributor

tischi commented Jan 21, 2022

@NicoKiaru @bogovicj When launching BigWarp the second time, I have more sources (Bigwarp *) in the source tree, do you know why they are there and how I could avoid this?

image

@tischi
Copy link
Contributor

tischi commented Jan 22, 2022

...ideal would be if it would only show the MoBIE - BigDataViewer sources. I think this should be possible by means of some SourceAndConverterProvider for the BdvPlaygroundActionCommand, is it? I don't remember the details...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants