prevent expensive queries to gtfs-api (PostgREST) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
force-pushed
the
gtfs-no-expensive-queries
branch
from
8625e41 to
4d4bb3b
Compare
After some testing, I've come to the conclusion that we could easily increase this to ~1m. Depending on the query, with highly varying results, I have measured an estimated cost of ~1m to be roughly equivalent to 0.2s-5s of querying wall clock time. |
derhuerst
changed the title
derhuerst
force-pushed
the
gtfs-no-expensive-queries
branch
2 times, most recently
from
710cea7 to
71b4029
Compare
hbruch
reviewed
Nov 17, 2023
[email protected] adds support for $POSTGREST_PASSWORD
derhuerst
force-pushed
the
gtfs-no-expensive-queries
branch
from
71b4029 to
d2d0b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the commits of #28. Merge that one first.
postgrest(before it re-usedpostgres).postgresthas a "global" limit, so that i can only make queries with costs<100000.web_anon) – PostgREST supposedly has a mechanism to circumvent limitations in PostgreSQL, but it doesn't seem to work.Do we want to keep the additional 30s query timeout in pgbouncer (8625e41)? Given that it applies to all underlying databases, I'd be careful.