aioenet not updating current values?

[nestorix1343]

I have the impression that aioenet.py is not updating the current values of an Actuator when an event is being handled.

In aioenet.py, line 149-152:

for value_spec in values:
    value = value_spec["value"]
    log.debug("Updating value of %s to %s", device, value)
    device.state = value

I can not really find device.state being used anywhere.

Shouldn't this be replaced with the line:

device.update_values(function_uid, values)

[mnordseth]

The code you point to is currently not in use, events is handled in EnertCoordinator at the moment. Why do you believe they are not handled? You will have to enable debugging to see those log lines.

…

On Tue, Sep 3, 2024, 18:08 Marcel ***@***.***> wrote: I have the impression that aioenet.py is not updating the current values of an Actuator when an event is being handled. In aioenet.py, line 149-152: for value_spec in values: value = value_spec["value"] log.debug("Updating value of %s to %s", device, value) device.state = value I can not really find device.state being using anywhere. Shouldn't this be replaced with the line: device.update_values(function_uid, values) — Reply to this email directly, view it on GitHub <#35>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARX6LHFOJRUD22M2M55CXDZUXNJNAVCNFSM6AAAAABNSPCBYWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYDGMRWGMZTSOA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[nestorix1343]

I am using the aioenet for another piece of software (eNet to MQTT) and I am not using any code which depends on HomeAssistant. The aioenet "library" is basically doing exactly what I need, except it goes wrong (or in any case does not do what I expected) with storing current values of Actuators.

I can/will fix this in the version I am using but I thought my remark could help a little bit.

[mnordseth]

Ok, got it! I have a plan to move the event logic into aioenet, but I have little time right now to spend on this. Would appreciate a pull request if you fix it.

…

On Tue, Sep 3, 2024, 20:53 Marcel ***@***.***> wrote: I am using the aioenet for another piece of software (eNet to MQTT) and I am not using any code which depends on HomeAssistant. The aioenet "library" is basically doing exactly what I needs, except it goes wrong (or in any case does not do what I expected) with storing current values of Actuators. I can/will fix this in the version I am using but I thought my remark could help a little bit. — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARX6LAE2DAXDEVVFSQY333ZUYAR5AVCNFSM6AAAAABNSPCBYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGIYDCNJSGY> . You are receiving this because you commented.Message ID: ***@***.***>

[nestorix1343]

Will do after I integrated the current/new aioenet version in my project. At this time I am still using an older version of it and I am working on using the new one as I like the event handling being integrated more in aioenet now. Saves me a lot of nasty code in my project.