Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Duplicate Code' issue in packages\core\manifest\src\open-api\services\open-api-auth.service.ts #165

Closed
codefactor-io bot opened this issue Sep 24, 2024 · 3 comments
Closed

Fix 'Duplicate Code' issue in packages\core\manifest\src\open-api\services\open-api-auth.service.ts #165

codefactor-io bot opened this issue Sep 24, 2024 · 3 comments
Assignees
@vitalymatyushik
Labels
good first issue Good for newcomers

Comments

@codefactor-io
Copy link

codefactor-io bot commented Sep 24, 2024

CodeFactor found an issue: Duplicate Code

It's currently on:
packages\core\manifest\src\open-api\services\open-api-auth.service.ts:61-76
packages\core\manifest\src\open-api\services\open-api-auth.service.ts:232-247
Commit d0351fa
@vitalymatyushik
Copy link

good day @SebConejo!
may I take it to be onboarded into the repo?

@vitalymatyushik vitalymatyushik mentioned this issue Oct 21, 2024
Merged
6 tasks
@vitalymatyushik
Copy link

good day @brunobuddy!
I've made small change to address the issue: please share your thoughts if it's needed or can be differently addressed 🙏

@brunobuddy
Copy link
Contributor

Closing as not important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitalymatyushik vitalymatyushik

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brunobuddy @SebConejo @vitalymatyushik