Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cnt response #13007

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Fix cnt response #13007

merged 9 commits into from
Dec 6, 2024

Conversation

withmywoessner
Copy link
Contributor

@withmywoessner withmywoessner commented Dec 5, 2024

Reference issue

Fixes #13006
Closes #13005

What does this implement/fix?

Currently all annotation descriptions are imported from event.StimType. This means all responses are recorded as 0, even when they should be read as a number representing the button the participant pressed. I correctly imported the response and appended KeyPad Response and Keyboard Response to the annotation because MNE does not differentiate explicitly between stimuluses and responses like Neuroscan does.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny idea for cleaner string mangling, and needs a doc/changes/devel/bugfix.rst since I think this qualifies as a bug

mne/io/cnt/cnt.py Outdated Show resolved Hide resolved
mne/io/cnt/cnt.py Outdated Show resolved Hide resolved
@larsoner larsoner merged commit d47c22f into mne-tools:main Dec 6, 2024
28 checks passed
@larsoner
Copy link
Member

larsoner commented Dec 6, 2024

Thanks @withmywoessner !

@withmywoessner withmywoessner deleted the fix_cnt_response branch December 6, 2024 17:03
scottrbrtsn pushed a commit to scottrbrtsn/mne-python that referenced this pull request Dec 6, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Larson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neuroscan CNT file responses read improperly read_raw_cnt() only raises one type of error
3 participants