-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cnt response #13007
Merged
Merged
Fix cnt response #13007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny idea for cleaner string mangling, and needs a doc/changes/devel/bugfix.rst
since I think this qualifies as a bug
Co-authored-by: Eric Larson <[email protected]>
Co-authored-by: Eric Larson <[email protected]>
for more information, see https://pre-commit.ci
withmywoessner
requested review from
drammock,
agramfort and
dengemann
as code owners
December 5, 2024 23:00
mscheltienne
approved these changes
Dec 6, 2024
Thanks @withmywoessner ! |
scottrbrtsn
pushed a commit
to scottrbrtsn/mne-python
that referenced
this pull request
Dec 6, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Larson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #13006
Closes #13005
What does this implement/fix?
Currently all annotation descriptions are imported from event.StimType. This means all responses are recorded as 0, even when they should be read as a number representing the button the participant pressed. I correctly imported the response and appended
KeyPad Response
andKeyboard Response
to the annotation because MNE does not differentiate explicitly between stimuluses and responses like Neuroscan does.