-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeChange, TimeBrowse, ChannelBrowse in ui-event system #12821
Comments
@wmvanvliet I created this issue due to the large number of ideas we discussed earlier. We can list PRs here and come up with a step-by-step plan |
To add some context; we would like to:
Both these cases deal with time, but in a different manner. The existing |
Sounds reasonable to me! Agreed you need separate event types |
Some code I made for mne-qt-browser using
|
@wmvanvliet I made a draft pull request with this implementation in qt databrowser. Scrolling through time and channels is working. Requires checking out mne-python branch #12819 |
Describe the new feature or enhancement
Create new
UIEvent
subclasses and update functions to handle when figures on the event system change:TimeChange
TimeBrowse
ChannelBrowse
All three different events could be experienced in the databrowser (MNE or Qt)
Describe your proposed implementation
Create new classes:
TimeBrowse
andChannelBrowse
to enable figures and databrowsers to update depending on the type of changeDescribe possible alternatives
NA
Additional context
PR for adding
TimeBrowse
andChannelBrowse
ui events #12819The text was updated successfully, but these errors were encountered: