Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document RasterMetricSpace and find faster implementation post-SciPy 1.13 #178

Open
rhugonnet opened this issue Apr 9, 2024 · 2 comments

Comments

@rhugonnet
Copy link
Contributor

Raises:
E AttributeError: 'dok_matrix' object has no attribute '_update'

It was actually expected. At this line, I had made a comment that it was only a temporary solution to make the computation faster: https://github.com/mmaelicke/scikit-gstat/blob/main/skgstat/MetricSpace.py#L783
I'll take some time soon to look up if a fast solution is still possible with the latest release without calling a non-public method, otherwise uncomment the slower solution above.

Maybe it's the occasion to also streamline this RasterMetricSpace and add some documentation on it. It was a bit of a first draft when I first added it.

@mmaelicke
Copy link
Owner

Sounds good to me, thanks! Let me know if there is anything you want me to review.

@rhugonnet rhugonnet changed the title Scipy 1.13.0 update breaks RasterMetricSpace Document RasterMetricSpace and find faster implementation post-SciPy 1.13 Sep 5, 2024
@rhugonnet
Copy link
Contributor Author

Errors due to SciPy 1.13 fixed by using the slower method in #185 (see #186).
Method dok_matrix.update still does not work, but there might be a new solution to keep the faster method, will look into it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants