add astream and vstream properties to avformat producer #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmatherly
requested changes
Aug 23, 2023
ddennedy
force-pushed
the
relative-stream-index
branch
from
08d57a9 to
4b5a3ed
Compare
bmatherly
reviewed
Aug 23, 2023
video_index can be used to index the streams array when it has a value of -1. This is a regression caused by 35402e6
bmatherly
approved these changes
Aug 24, 2023
When opening an existing project that has only audio_index and video_index using the avformat-novalidate producer these properties are not set in producer init. This makes Shotcut unable to locate the relative stream indices in its Properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still testing this, and there are Shotcut changes required to take advantage of it that shows it basically working. But I want to give you a chance to review it. This is usable from the command line using
astream=1on the melt command line, for example, to choose the second audio stream (much easier than figuring out or guessing the absolute stream index when you do not know the order of streams - or in the case of a Google Pixel video where the first stream is a data stream). The Pixel video breaks exporting with a proxy in Shotcut because the absolute stream indexes between the source and proxy do not match since the proxy transcode process drops the data stream.I added this private Pixel video to our shared S3 folder in
Google Pixelfolder. I also added a video with 2 video streams and 2 audio streams (as well as some data streams, as created by a GoPro MAX 360 video camera) to a foldermultiple video and audio streams.