Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Comments Indicator #654

Closed
EricBAndrews opened this issue Sep 25, 2023 · 2 comments
Closed

New Comments Indicator #654

EricBAndrews opened this issue Sep 25, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@EricBAndrews
Copy link
Member

EricBAndrews commented Sep 25, 2023

Add an optional indicator to the post view to tell the user if the post has new comments since they last viewed it.

Backend:
It looks like the API has something approaching support for this--read_post performs a count of the comments at the time of read. If we can get that information when we fetch a post, we could use in the obvious manner to determine if there are new comments.

Frontend:
Replace the standard comment indicator with text.bubble when there are new replies

Ideally we could then highlight the comments themselves. It may be necessary to perform client-side caching of read comments, which shouldn't be too expensive--all we'd need to store is the id, which is only a few bytes.

@EricBAndrews EricBAndrews added the enhancement New feature or request label Sep 25, 2023
@EricBAndrews EricBAndrews added this to the Future milestone Sep 25, 2023
@EricBAndrews EricBAndrews moved this from To Triage to Backlog in Development Tracker Oct 10, 2023
@Sjmarf
Copy link
Member

Sjmarf commented Dec 11, 2023

PostView has an unread_comments integer value that we could use to do this. It won't tell us which comments are new, but it'll tell us that they exist. https://join-lemmy.org/api/interfaces/PostView.html#unread_comments

@Sjmarf Sjmarf self-assigned this Dec 27, 2023
@Sjmarf
Copy link
Member

Sjmarf commented Jan 19, 2024

Added in #858

@Sjmarf Sjmarf closed this as completed Jan 19, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Finished in Development Tracker Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants