-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some models fail to prepare tokens: No chat template #150
Comments
Base models don't usually have a chat template. Is there something like https://github.com/ml-explore/mlx-examples/blob/main/llms/mlx_lm/generate.py#L213C1-L214C1 in Swift Transformers? |
No, nothing like that: https://github.com/huggingface/swift-transformers/blob/main/Sources/Tokenizers/Tokenizer.swift#L359 Perhaps there should be? @pcuenca @maiqingqiang |
I agree. Similar to https://github.com/huggingface/transformers/blob/33868a057c02f0368ba63bd1edb746be38fe3d90/src/transformers/tokenization_utils_base.py#L1628-L1629 Alternatively, it could capture |
Per above I added a workaround -- it will try to apply the template, but if that throws an error it will fall back to a built in template and tokenization. |
For models that have a chat template this is fine, but for those that do not:
I think we need to do the config-mutate path and inject a template where needed.
The text was updated successfully, but these errors were encountered: