Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstracting away the GPU #23

Closed
jaywonchung opened this issue Oct 8, 2023 · 0 comments · Fixed by #46
Closed

Abstracting away the GPU #23

jaywonchung opened this issue Oct 8, 2023 · 0 comments · Fixed by #46
Assignees
Labels
enhancement New feature or request

Comments

@jaywonchung
Copy link
Member

Right now, the codebase is full of random calls to pynvml methods. nvmlInit is being called everywhere (leading to duplicate initializations, which is fine but not ideal). NVML device handles are either passed around randomly or re-instantiated every time.

It would be nice to abstract away the GPUs into a single class that exposes the methods that wrap NVML for consistent error handling and logging. For now this is a code quality enhancement, but with #22 coming in, this will be mandatory.

@jaywonchung jaywonchung added the enhancement New feature or request label Oct 8, 2023
@parthraut parthraut self-assigned this Feb 11, 2024
@parthraut parthraut linked a pull request Mar 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants