Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing option for encoding in buffer reads. #157

Open
Gulars2000 opened this issue Jan 22, 2020 · 2 comments
Open

Missing option for encoding in buffer reads. #157

Gulars2000 opened this issue Jan 22, 2020 · 2 comments

Comments

@Gulars2000
Copy link

Hi i had troubles when doing parralel sessions, afers some troubleshoooring i realised that your buf.toString(), statements didnt incllude encoding.
Since telnet is 7 bit ascii this created a few weird issues.
i added encoding ascii to all 3 empty buf.toString() statements and it seemed to solve the issues.

@mkozjak
Copy link
Owner

mkozjak commented Jan 22, 2020

Care to do a PR?

@mkozjak
Copy link
Owner

mkozjak commented Jan 25, 2020

This solution should be done in a way to respect telnet negotiations for charset, eg. IAC SB CHARSET ACCEPT "UTF-8" IAC SE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants